Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect math #1

Open
JazzMaster opened this issue Sep 27, 2018 · 0 comments
Open

incorrect math #1

JazzMaster opened this issue Sep 27, 2018 · 0 comments

Comments

@JazzMaster
Copy link

if you multiply by ZERO- you get ZERO.

If you get any other value- your subroutines are WRONG. Do I need to take you back to basic algebra? Look at the top lines of that code- its posted everywhere, btw, and its WRONG.

ZERO x anything = ZERO.

"require a ==0" in safeMUL():

you mean: require a <>(not) 0
or : require a !=0

Otherwise you have more code to fix and there is a SERIOUS FLAW somewhere else in the token algorithms.

Surprised nobody caught this as any decent programmer would have paid attention. Most of the other code is spot on. Eyes on logic bombs like this- I dont care how well you write the code-- if theres a bomb in it- it wont work as expected.

This is basic algebra here, folks. I could understand if it was warp factor math or planks equation.

YW for the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant