Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to include the new parameter task,version,seed #222

Open
MarleneKress79789 opened this issue May 7, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@MarleneKress79789
Copy link
Collaborator

Downloading a model and saving it locally using AutoModel.from_pretrained loses the model specialization (detailed description in #213) . After loading these broken models, using them for prediction returns bad results.

  • We see only one option to solve this problem, and this is to specify the task during download of the model.
    • This means the download udf and the upload cli need an additional parameter for the task
      • The task should be part of the name of the uploaded model file, such that users can upload a model for multiple tasks
      • Furthermore, we should store the task inside the model archive file
  • To solve the testing issues, we need to make the prediction udfs deterministic
    • For this, we need to be able to download a fixed version of a model and set the seed inside the prediction udf.
    • This means we need a version parameter in download udf, prediction udf and model upload cli
      • The version should be part of the name of the uploaded model file, such that users can upload multiple versions
    • We need a seed parameter in the prediction udfs

we need to document the changes made for this before releasing. Check changes in #216, #217, #218, #219, #220, #221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant