Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the test framework for the package management scripts #797

Open
tkilias opened this issue May 15, 2023 · 1 comment
Open

Rework the test framework for the package management scripts #797

tkilias opened this issue May 15, 2023 · 1 comment
Labels
blocked:yes Currently blocked by another ticket refactoring Code improvement without behavior change

Comments

@tkilias
Copy link
Collaborator

tkilias commented May 15, 2023

Background

  • We currently use some bash scripts to the package management scripts.
  • Because of install_via_pip.pl might downgrade already installed packages  #794 the tests get more complicates such that we should move these tests to python.
  • We have two types of tests:
    1. Simple unit tests which compare the generated commands
    2. System-tests which run the commands in a docker container
  • Currently, both use the same scripts; however, the system-tests can only test of the commands are running without failing, but not the changes of the environment
  • Further, currently share all tests of one script, the same docker container

Acceptance Criteria

  • Implement the tests as pytest tests
  • Use a fixture to create a new docker container for each system-test
  • Add checks of the environment for the system-tests
@tkilias tkilias added the refactoring Code improvement without behavior change label May 15, 2023
@tkilias tkilias added the blocked:yes Currently blocked by another ticket label May 25, 2023
@tkilias
Copy link
Collaborator Author

tkilias commented May 25, 2023

Blocked, because it needs #242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked:yes Currently blocked by another ticket refactoring Code improvement without behavior change
Projects
None yet
Development

No branches or pull requests

1 participant