Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Enable Type Checking for the Project #52

Open
Nicoretti opened this issue Nov 18, 2024 · 0 comments
Open

🔧 Enable Type Checking for the Project #52

Nicoretti opened this issue Nov 18, 2024 · 0 comments
Labels
refactoring Code improvement without behavior change

Comments

@Nicoretti
Copy link
Member

Summary

Enable type checking for the project to ensure code quality and consistency with recent upgrades to our Python toolbox.

Details

We need to update our pyproject.toml file to re-enable type checking for the following modules and files:

[[tool.mypy.overrides]]
module = [
    "exasol.*",
    "noxfile",
    "noxconfig",
]

Background & Context

Despite not performing type checks previously, with our upgrade to the latest Python toolbox, type checking has been introduced into our workflows. To maintain coherence with common setups and to facilitate future updates, we have retained the type checking step but disabled it for the project files in the pyproject.toml.

Our goal now is to re-enable type checking and resolve any typing errors present in the project files.

Action needed: Re-enable type checking for the specified modules and address any resulting type errors.

You can find the relevant configuration under the tool.mypy.overrides section in the pyproject.toml file.

@Nicoretti Nicoretti added the refactoring Code improvement without behavior change label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

No branches or pull requests

1 participant