Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QueryHandler Dataflow Abstraction #212

Open
ckunki opened this issue Nov 12, 2024 · 3 comments · May be fixed by #213
Open

Add QueryHandler Dataflow Abstraction #212

ckunki opened this issue Nov 12, 2024 · 3 comments · May be fixed by #213
Assignees
Labels
feature Product feature

Comments

@ckunki
Copy link
Contributor

ckunki commented Nov 12, 2024

@ckunki ckunki added the feature Product feature label Nov 12, 2024
@ckunki
Copy link
Contributor Author

ckunki commented Nov 12, 2024

Affected test files

Clearly related

Other files below folder tests/ with imports from sql_stage_graph_execution

@tkilias: None of these files is related and hence we don't need to move any of these.

File Imports
test_output_generator.py SQLStageInputOutput
create_model_runner_asserts.py SQLStageGraphExecutionInput, SQLStageInputOutput
create_model_runner_test_setup.py Dataset, SQLStageGraphExecutionQueryHandler
test_create_model_input_to_dataset_converter.py Dataset
test_create_model_runner.py SQLStageInputOutput
test_output_generator.py DataPartition, Dataset, SQLStageInputOutput
test_create_model_runner_integration.py DataPartition, Dataset, SQLStageInputOutput
stage_graph_split_test_utils.py SQLStageInputOutput
test_pydantic_estimator_to_sql_stage_graph.py SQLStageInputOutput

@ckunki ckunki self-assigned this Nov 12, 2024
@ckunki
Copy link
Contributor Author

ckunki commented Nov 13, 2024

Dependencies

from exasol_machine_learning_library.execution

The files marked with ✅ had already been are listed as dependencies needing to be moved, too, in the main comment of the current ticket above.

File Import Comment
sql_stage_graph.sql_stage_graph SQLStageGraph
stage_graph.stage SQLStage
stage_graph.sql_stage_train_query_handler SQLStageTrainQueryHandlerInput ✅ Added to list of dependencies above

from exasol_machine_learning_library.execution.sql_stage_graph_execution

✅ These files are planned to be moved, anyway

File Import
data_partition DataPartition
dataset Dataset
dependency Dependencies
find_object_proxies find_object_proxies
object_proxy_reference_counter ObjectProxyReferenceCounter, ReferenceCounterStatus
object_proxy_reference_counting_bag ObjectProxyReferenceCountingBag
sql_stage_graph_execution_input SQLStageGraphExecutionInput
sql_stage_graph_execution_query_handler_state SQLStageGraphExecutionQueryHandlerState, ResultHandlerReturnValue
sql_stage_input_output SQLStageInputOutput

from exasol_advanced_analytics_framework

✅ These files are already available in AAF

File Import
query_handler.context.proxy.db_object_name_proxy ObjectProxy
query_handler.context.proxy.object_proxy ObjectProxy
query_handler.context.scope_query_handler_context ScopeQueryHandlerContext
query_handler.query_handler QueryHandler
query_handler.result Continue, Finish
query_result.query_result QueryResult

from exasol_bucketfs_utils_python.abstract_bucketfs_location import AbstractBucketFSLocation

from exasol_data_science_utils_python.schema.column

✅ These files are already available in AAF

File Import
schema.column Column
schema.table_like TableLike
utils.data_classes_runtime_type_check check_dataclass_types

@ckunki
Copy link
Contributor Author

ckunki commented Nov 15, 2024

Observations
MLL test_find_object_proxies.py skips some test cases

  • test_object_proxy_in_table[VIEW_NAME]
  • test_object_proxy_in_table[BUCKETFS_LOCATION]
  • test_object_proxy_in_view[TABLE_NAME]
  • test_object_proxy_in_view[BUCKETFS_LOCATION]
  • test_object_proxy_in_column_name[VIEW_NAME]
  • test_object_proxy_in_column_name[BUCKETFS_LOCATION]
  • test_object_proxy_in_column[VIEW_NAME]
  • test_object_proxy_in_column[BUCKETFS_LOCATION]

This is due to pytest.skip() in some test cases

@ckunki ckunki changed the title Move DataFlow Abstraction from MLLib to AAF Add QueryHandler Dataflow Abstraktion Nov 18, 2024
@ckunki ckunki changed the title Add QueryHandler Dataflow Abstraktion Add QueryHandler Dataflow Abstraction Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Product feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant