From 5fb61949deec3a0e8e7461bf8ea717f6123917be Mon Sep 17 00:00:00 2001 From: Evgeny Kotov Date: Mon, 1 Apr 2024 16:34:01 +0200 Subject: [PATCH] code review fixes --- src/frontends/tensorflow/src/op/while.cpp | 4 +++- src/frontends/tensorflow/src/tf_utils.cpp | 8 +------- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/frontends/tensorflow/src/op/while.cpp b/src/frontends/tensorflow/src/op/while.cpp index 396168df313eac..a29503bee55893 100644 --- a/src/frontends/tensorflow/src/op/while.cpp +++ b/src/frontends/tensorflow/src/op/while.cpp @@ -42,7 +42,9 @@ OutputVector translate_while_op(const NodeContext& node) { body_model, "[TensorFlow Frontend] Internal error or incorrect input model. Cannot find body graph with name " + body_type); - return create_loop_for_tf_while(node.get_name(), body_model, cond_model, ov_inputs); + auto loop_outputs = create_loop_for_tf_while(node.get_name(), body_model, cond_model, ov_inputs); + set_node_name(node.get_name(), loop_outputs[0].get_node_shared_ptr()); + return loop_outputs; } } // namespace op diff --git a/src/frontends/tensorflow/src/tf_utils.cpp b/src/frontends/tensorflow/src/tf_utils.cpp index 657a5abcb343bb..b804d09b8b0a6a 100644 --- a/src/frontends/tensorflow/src/tf_utils.cpp +++ b/src/frontends/tensorflow/src/tf_utils.cpp @@ -467,13 +467,8 @@ bool propagate_conditional_flow(const OutputVector& ov_inputs, namespace { shared_ptr get_parent_parameter(const shared_ptr& node) { const auto input_values = node->input_values(); - if (input_values.empty()) - return {}; return as_type_ptr(input_values[0].get_node_shared_ptr()); } -bool has_parent_parameter(const shared_ptr& node) { - return get_parent_parameter(node) != nullptr; -} } // namespace // create Loop operation corresponding to TensorFlow While operation @@ -558,7 +553,7 @@ ov::OutputVector create_loop_for_tf_while(const std::string& while_node_name, std::vector invariant_input_indexes; // body_results may contain less nodes than body_params that means back edge exists not for all body_params for (size_t input_ind = 0; input_ind < body_condition_output_idx; ++input_ind) { - if (has_parent_parameter(body_results[input_ind])) { + if (get_parent_parameter(body_results[input_ind])) { invariant_input_indexes.push_back(input_ind); continue; } @@ -594,7 +589,6 @@ ov::OutputVector create_loop_for_tf_while(const std::string& while_node_name, } loop->validate_and_infer_types(); - set_node_name(while_node_name, loop); return loop_outputs; }