Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a reference test suite for implementations to use #12

Closed
mperham opened this issue Mar 23, 2023 · 2 comments
Closed

Provide a reference test suite for implementations to use #12

mperham opened this issue Mar 23, 2023 · 2 comments

Comments

@mperham
Copy link

mperham commented Mar 23, 2023

I'd like to work on a Ruby version but this repo has no easy way for me to verify my implementation. Looks like there is already a lot of demo image data on the demo website which could be used as part of an automated test suite.

@evanw
Copy link
Owner

evanw commented Mar 23, 2023

The images and hashes on the demo website are a good set of tests. If you can render appropriate-looking images with those hashes then your code should be working.

Someone asked for a similar thing for BlurHash too: woltapp/blurhash#38. I also agree with the response there. These things are meant to be a very loose very blurry representation of the image, so exact accuracy isn't the goal. It doesn't matter if you end up a few bits off due to e.g. using doubles vs. floats. So I don't think an automated test suite is the right approach here.

@mperham
Copy link
Author

mperham commented Mar 23, 2023

Fair enough.

@mperham mperham closed this as completed Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants