Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Oracle Database #50

Closed
evangelosmeklis opened this issue Sep 28, 2024 · 3 comments · May be fixed by #67
Closed

Support for Oracle Database #50

evangelosmeklis opened this issue Sep 28, 2024 · 3 comments · May be fixed by #67
Labels
feature A big implementation good first issue Good for newcomers

Comments

@evangelosmeklis
Copy link
Owner

No description provided.

@evangelosmeklis evangelosmeklis added good first issue Good for newcomers feature A big implementation labels Sep 28, 2024
@Aherontas
Copy link
Collaborator

Dropped for now support for Oracle Database.

@Peter-Fayez95
Copy link

Hello! I really like PeepDB and I'm interested in contributing Oracle Database support to the project. I've started working on an implementation using python-oracledb as the driver.

My initial implementation plan includes:

  1. Adding a new OracleDatabase class that extends BaseDatabase
  2. Implementing core functionality for connecting, querying, and pagination
  3. Supporting features like table listing and schema inspection
  4. Adding appropriate error handling and logging

Would love to get feedback on this approach before proceeding further. Let me know if there are specific requirements or considerations I should keep in mind while implementing this.

I can share an initial PR with the basic implementation for review once I have the core functionality working.

@evangelosmeklis
Copy link
Owner Author

@Peter-Fayez95 Hello. Sorry for the delayed answer. Please open a PR when you are ready so we can review. Also, please don't forget to add unittests.

@Peter-Fayez95 Peter-Fayez95 mentioned this issue Jan 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature A big implementation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for Oracle Database Peter-Fayez95/peepdb
3 participants
@Aherontas @evangelosmeklis @Peter-Fayez95