Skip to content
This repository has been archived by the owner on Aug 30, 2024. It is now read-only.

[RFC] possibly merge this into main sosreport tree #68

Open
adam-stokes opened this issue Jul 31, 2014 · 5 comments
Open

[RFC] possibly merge this into main sosreport tree #68

adam-stokes opened this issue Jul 31, 2014 · 5 comments

Comments

@adam-stokes
Copy link

Hi!

I happened to come across this branch and was curious if I could help you possibly get these plugins merged into the main sosreport tree?

Thanks
Adam

@hspencer77
Copy link
Member

Hey Adam,

So sorry for the late response here. I have been away on some personal business. I would love your help here. Please let me know how you would like to proceed. Look forward to hearing from you soon.

Kind Regards,

Harold Spencer, Jr.

@adam-stokes
Copy link
Author

If you're OK with it I was going to take what you have and get it in a state to be merged into the main sosreport tree and create an issue to be reviewed and merged upstream.

I also noticed that there are a couple branches that relate to older versions of sosreport, which branch should I be pulling from that you would like upstream?

@bmr-cymru
Copy link

Thanks for kicking this off Adam! From a quick scan it looks like there's a few easy fixes:

  • convert from 2.x plugin API to 3.x

  • Replace package-checking check_installed() methods with packages lists

  • Convert open coded subprocess use to plugin API calls

  • Move iptables-save-counters into networking plugin

  • Convert tmpfiles use into Archive API

    The big jobs are probably going to be eucadb (can we re-use the existing postgresql support?) and eucafrontend but we can get things compatible with the current tree first and then consider those cases.

@adam-stokes
Copy link
Author

The big jobs are probably going to be eucadb (can we re-use the existing postgresql support?) and eucafrontend but we can get things compatible with the current tree first and then consider those cases.

Yea im hoping we can use the existing pg plugin for eucadb

@hspencer77
Copy link
Member

Hey Adam,

Latest branch we push as an RPM is from master. With the eucadb module, we can definitely review to see if the pg plugin can be used. The main goal for the eucadb module was to keep things centralized regarding Eucalyptus specific information. However I feel that there are some improvements that can be done here. I really appreciate the review and feedback that you and bmr-cymru are providing.

Please let me know if there are any additional questions. Also, let me know what additional tasks you need me to do.

Cheers,

Harold Spencer, Jr.

hspencer77 added a commit to hspencer77/eucalyptus-sosreport-plugins that referenced this issue Feb 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants