Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All internal links open in new tab #617

Closed
soxofaan opened this issue Sep 12, 2024 · 3 comments · Fixed by #628
Closed

All internal links open in new tab #617

soxofaan opened this issue Sep 12, 2024 · 3 comments · Fixed by #628

Comments

@soxofaan
Copy link
Collaborator

It seems that at the moment, all internal links in de CDSE docs open in a new tab

e.g. https://documentation.dataspace.copernicus.eu/APIs/openEO/openEO.html#added-value-of-openeo-api

comes from

* Independence from underlying technologies and software libraries.
* Reproducibility through transparent workflows, [supporting principles of FAIR](fair.qmd) (Findable, Accessible, Interoperable, and Reusable) and Open Science.
When using the openEO API, users can choose [JavaScript](JavaScript_Client/JavaScript.qmd), [Python](Python_Client/Python.qmd), or [R](R_Client/R.qmd) as their client library. This allows them to work with any backend and compare them based on capacity, cost, and result quality.

which has a bunch of internal links :

... choose [JavaScript](JavaScript_Client/JavaScript.qmd), 
[Python](Python_Client/Python.qmd), or [R](R_Client/R.qmd) as ...

But that currently results in a target="_blank" link that opens in a new tab:
image

@soxofaan
Copy link
Collaborator Author

even the section header fragment links have it:

image

@soxofaan
Copy link
Collaborator Author

It seems the target=_blank is added from Javascript and this are the relevant configs:

documentation/_quarto.yml

Lines 343 to 344 in c335239

link-external-newwindow: true
link-external-filter: '^(?:http:|https:)\/\/documentation.*dataspace.copernicus\/custom'

@soxofaan
Copy link
Collaborator Author

The docs on link-external-filter are pretty confusing actually: quarto-dev/quarto-cli#10780

soxofaan added a commit that referenced this issue Sep 30, 2024
Issue #617 fix detection of "internal" links with link-external-filter config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant