From 5557f79305b7be60ad6294b8960a011dc97e9e12 Mon Sep 17 00:00:00 2001 From: Lucano Vera Date: Mon, 13 Jan 2025 11:27:10 -0300 Subject: [PATCH 1/2] Fix cypress e2e pipeline (#5659) --- .github/workflows/cypress_e2e.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/cypress_e2e.yml b/.github/workflows/cypress_e2e.yml index 952e4fc46d..7da0f97836 100644 --- a/.github/workflows/cypress_e2e.yml +++ b/.github/workflows/cypress_e2e.yml @@ -26,6 +26,11 @@ jobs: - name: Checkout uses: actions/checkout@v4 + - name: Setup Python 3.10 + uses: actions/setup-python@v5 + with: + python-version: "3.10" + - name: Install Nox run: pip install nox>=2022 From 73188c53f9479cd6dbd4f3637a4fc03faec9d3cf Mon Sep 17 00:00:00 2001 From: Lucano Vera Date: Mon, 13 Jan 2025 12:06:42 -0300 Subject: [PATCH 2/2] LA-203 Update-CMP-Privacy-Center-powered-by-URL-to-https-ethyca.com (#5656) --- CHANGELOG.md | 3 +++ clients/fides-js/src/components/BrandLink.tsx | 2 +- clients/fides-js/src/components/EthycaLogo.tsx | 2 ++ clients/privacy-center/components/BrandLink.tsx | 10 +++++++++- .../privacy-center/cypress/e2e/consent-banner.cy.ts | 2 +- .../public/fides-js-components-demo.html | 1 + 6 files changed, 17 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1862215a98..074f760587 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -25,6 +25,9 @@ Changes can also be flagged with a GitHub label for tracking purposes. The URL o - Added Action Center MVP behind new feature flag [#5622](https://github.com/ethyca/fides/pull/5622) - Added cache-clearing methods to the `DBCache` model to allow deleting cache entries [#5629](https://github.com/ethyca/fides/pull/5629) +### Changed +- Updated brand link url [#5656](https://github.com/ethyca/fides/pull/5656) + ### Fixed - Fixed issue where the custom report "reset" button was not working as expected [#5649](https://github.com/ethyca/fides/pull/5649) - Fixed column ordering issue in the Data Map report [#5649](https://github.com/ethyca/fides/pull/5649) diff --git a/clients/fides-js/src/components/BrandLink.tsx b/clients/fides-js/src/components/BrandLink.tsx index dd84bb79ef..a22a207743 100644 --- a/clients/fides-js/src/components/BrandLink.tsx +++ b/clients/fides-js/src/components/BrandLink.tsx @@ -5,7 +5,7 @@ import EthycaLogo from "./EthycaLogo"; const BrandLink = () => (
( height="20" fill="currentColor" className="ethyca-logo" + role="img" + aria-label="Ethyca" > diff --git a/clients/privacy-center/components/BrandLink.tsx b/clients/privacy-center/components/BrandLink.tsx index 15976ceb06..d614c0afd6 100644 --- a/clients/privacy-center/components/BrandLink.tsx +++ b/clients/privacy-center/components/BrandLink.tsx @@ -22,9 +22,17 @@ const BrandLink = ({ right={right} textDecoration="none" _hover={{ textDecoration: "none" }} + href="https://ethyca.com/" {...props} > - Powered by + Powered by{" "} + ); }; diff --git a/clients/privacy-center/cypress/e2e/consent-banner.cy.ts b/clients/privacy-center/cypress/e2e/consent-banner.cy.ts index eeb1bf582d..ce2eae5e1e 100644 --- a/clients/privacy-center/cypress/e2e/consent-banner.cy.ts +++ b/clients/privacy-center/cypress/e2e/consent-banner.cy.ts @@ -333,7 +333,7 @@ describe("Consent overlay", () => { cy.get("a.fides-brand-link").should( "have.attr", "href", - "https://fid.es/powered", + "https://ethyca.com/", ); }); }); diff --git a/clients/privacy-center/public/fides-js-components-demo.html b/clients/privacy-center/public/fides-js-components-demo.html index b60af186d4..57ce779cd7 100644 --- a/clients/privacy-center/public/fides-js-components-demo.html +++ b/clients/privacy-center/public/fides-js-components-demo.html @@ -207,6 +207,7 @@ privacyCenterUrl: "http://localhost:3001", fidesApiUrl: "http://localhost:8080/api/v1", fidesPrimaryColor: "#008000", + showFidesBrandLink: true, }, }; if (init !== "false") {