-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposing to have flush()
method
#89
Comments
I think this might be a valuable addition to the API, yes. |
I'm not fully sure what problem this is solving, since the key is not cleared from memory. |
@axic Is it really so easy to read things from memory with JavaScript? |
I am just confused what benefit this gives. If a user of this library can call |
Hmm, that's the same with all libraries, theoretically you can use/access all (most) parts of the code but are encouraged to engage with the methods which are part of the public API, otherwise it's monkey-patching. 🐵 😄 |
I've tried to do some experiments and observe result. We can't remove the value from the memory easily
|
IMO having such a method would give a false sense of security to the users of this library. It's not easy to be sure that every copy of the key was erased, especially when the private key is used by external libraries. |
_privKey
and_pubKey
are always accessible that's make me uncomfortable. I'm propose to have this one.The text was updated successfully, but these errors were encountered: