What is the current behavior?

In async_ens.py, the address method calls:

r = await self.resolver(name)
if coin_type is None:
    return cast(ChecksumAddress, await self._resolve(name, "addr"))
else:
    ...

However, r is only used in the else branch (when coin_type is not None). This makes the call to await self.resolver(name) somewhat unnecessary when coin_type is None.

Proposed improvement

Move:

r = await self.resolver(name)

inside the else block so it’s only called when coin_type is not None, i.e.:

if coin_type is None:
    return cast(ChecksumAddress, await self._resolve(name, "addr"))
else:
    r = await self.resolver(name)
    ...

This should:

• Prevent the extra await self.resolver(name) call when it’s not used.
• Potentially be more readable, showing that r is only needed for multichain address lookups (coin_type != None).

Questions/Concerns

1. Does _resolve(name, "addr") internally call self.resolver(name) again, making this change inconsequential?
2. Are there any side effects (like caching) or known behaviors that rely on await self.resolver(name) being called regardless of coin_type?
3. Would this refactor break any tests or expectations?

Open Discussion

• Is this micro-optimization worth it for code clarity and performance?
• Or is it clearer to always call await self.resolver(name) in one place, even if the method doesn’t end up using it in the if branch?

Any feedback or guidance would be appreciated. If this change seems reasonable, I’m happy to open a PR—or if it’s not necessary, feel free to close this issue.

Cute Animal Picture