Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Browser Usage" in Readme probably wrong due to synchronous webassembly compilation #581

Open
ekpyron opened this issue Jan 7, 2022 · 1 comment
Labels
bug 🐛 documentation 📖 medium effort Default level of effort medium impact Default level of impact must have eventually Something we consider essential but not enough to prevent us from releasing Solidity 1.0 without it. Needs Investigation

Comments

@ekpyron
Copy link
Member

ekpyron commented Jan 7, 2022

We specifically compile soljson.js with WASM_ASYNC_COMPILATION=0 - there was a reason for this, but I don't remember right now.
However, I think at least chromium-based browsers won't allow synchronous compilation from the main thread. This effectively means that loading the compiler has to be done from web workers right now (at least if it's supposed to work in all browsers) and the "Browser Usage" section in README.md is outdated.

So we need to check if we can switch to asynchronous compilation in solidity, investigate if and what kind of problems synchronous compilation entails and adjust the section in the readme accordingly.

@jhubbardsf
Copy link

jhubbardsf commented Aug 8, 2022

Any updates on this? Still getting a compiler error when trying to load it in browser (chromium based).

@cameel cameel added bug 🐛 medium effort Default level of effort medium impact Default level of impact must have eventually Something we consider essential but not enough to prevent us from releasing Solidity 1.0 without it. documentation 📖 labels Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 documentation 📖 medium effort Default level of effort medium impact Default level of impact must have eventually Something we consider essential but not enough to prevent us from releasing Solidity 1.0 without it. Needs Investigation
Projects
No open projects
Status: Design/Decide
Development

No branches or pull requests

4 participants