Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidity <0.4.9 doesn't give file paths; is there any way for wrapper to repair this? #558

Open
haltman-at opened this issue Oct 12, 2021 · 3 comments

Comments

@haltman-at
Copy link

Again, filing this issue based on discussion in #555. Currently Truffle doesn't support Solidity <0.4.9 because the (wrapped) compiler output doesn't give file paths, but rather just groups every contract under the empty path. Over on #555, @cameel suggested it might be possible for solc/wrapper to repair this? I certainly hadn't considered that possibility! Well, just in case it is, I'm filing this issue as suggested. :)

@cameel
Copy link
Member

cameel commented Oct 13, 2021

This one is tricky. The problem is that the information is not there. I think it would be possible to reconstruct it based on the input as long as it's unambiguous. If you have multiple contracts with the same name in the input though, it's not going to be fixable - unless there's some other place in the output that does have paths. I'd have to take a look at the output format on this specific version.

@haltman-at
Copy link
Author

Yes, that's part of why I assumed this wasn't actually possible and hadn't considered asking for it until you suggested it...

@cameel
Copy link
Member

cameel commented Oct 13, 2021

@chriseth says that this is ok in the wrapper as long as it's not too complicated so I'll try to add a workaround when I have some time to work in this. In case anyone else would like to take this, PRs are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Implement
Development

No branches or pull requests

2 participants