Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consume): refine the --input flag for fixture releases #787

Open
spencer-tb opened this issue Sep 5, 2024 · 2 comments · May be fixed by #1044
Open

feat(consume): refine the --input flag for fixture releases #787

spencer-tb opened this issue Sep 5, 2024 · 2 comments · May be fixed by #1044
Assignees
Labels
scope:consume Scope: Consume command suite type:feat type: Feature

Comments

@spencer-tb
Copy link
Contributor

Implement the comments and suggests from #745.

From #745 (comment), add the following:

I think we should use the Github API to determine which release is the latest and then define input_source to the URL that points to a specific release (i.e., a URL containing v[0-9]+.[0-9]+.[0-9]+). This has a few benefits:

  1. The pytest header will display the correct release version (this is a must imho, so that you can quickly see which release was actually being executed).
  2. We can display the exact release in the consume commands displayed in hiveview to help reproduce tests.
  3. The extracted fixtures will be extracted to the correct cache directory.

Another approach would be to grab the version from the .meta/fixtures.ini file, but I thinkI prefer resolving latest. If we're being very careful, we could check that the resolved version matches that of .meta/fixtures.ini, but it's a bit paranoid.

From #745 (comment), consider adding the following:

  1. I was hoping a while ago to be able to add the release tag and fixture "tag" as input options.

So we could have --input=<release_tag|latest>-<fixture_tag>-release, for example:

  • --input=latest-stable-release equivalent to --input=v3.0.0-stable-release.
  • [email protected] for the EOF v1.0.7 fixtures.
    At this point we are may be going overkill! But at least if we include the former it covers all cases regarding releases.

I do still like URLs especially if pointing to releases outside of the main repo but then...
2) we could add git user names to the input!

@spencer-tb spencer-tb added type:feat type: Feature scope:consume Scope: Consume command suite labels Sep 5, 2024
@spencer-tb spencer-tb self-assigned this Sep 5, 2024
@spencer-tb
Copy link
Contributor Author

cc @danceratopz

@marioevz
Copy link
Member

Should be addressed by #1044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:consume Scope: Consume command suite type:feat type: Feature
Projects
None yet
2 participants