Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ci): use astral-sh/setup-uv with vars.UV_VERSION across all gh workflows #1062

Open
danceratopz opened this issue Jan 8, 2025 · 0 comments
Labels
scope:ci Scope: Continuous Integration type:refactor Type: Refactor

Comments

@danceratopz
Copy link
Member

danceratopz commented Jan 8, 2025

#1061 experimented with the astral-sh/setup-uv action.

This has some nice features:

  • specify uv version,
  • specify python version to use,
  • persist uv's cache between runs.

We main task is to use this action consistently across all workflows and ensure vars.UV_VERSION is used consistently.

Additionally, as this step's config is a few lines that'll get heavily repeated:

- name: Install uv ${{ vars.UV_VERSION }} and python ${{ vars.DEFAULT_PYTHON_VERSION }}
uses: astral-sh/setup-uv@v5
with:
enable-cache: true
cache-dependency-glob: "uv.lock"
version: ${{ vars.UV_VERSION }}
python-version: ${{ vars.DEFAULT_PYTHON_VERSION }}

we could consider adding this to .github/actions/setup-uv/action.yaml (instead of using a curl install, as it does now). This action could optionally take a PYTHON_VERSION and default to vars.DEFAULT_PYTHON_VERSION.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:ci Scope: Continuous Integration type:refactor Type: Refactor
Projects
None yet
Development

No branches or pull requests

1 participant