Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish built fixtures to a standalone repository #1055

Open
marioevz opened this issue Jan 7, 2025 · 2 comments
Open

Publish built fixtures to a standalone repository #1055

marioevz opened this issue Jan 7, 2025 · 2 comments

Comments

@marioevz
Copy link
Member

marioevz commented Jan 7, 2025

  • Add a step to .github/workflows/fixtures_feature.yaml and .github/workflows/fixtures.yaml to also push the built fixtures to a separate repository.
  • Each feature-built fixtures could live in a separate branch of this repository
  • We could explore either building for each PR merged and push that to the main branch, or having stable version of the repository be the main branch.
@winsvega
Copy link
Contributor

winsvega commented Jan 7, 2025

I would vote to use ethereum/tests repo for it. Just overwrite over it, move current develop to a separate branch or legacy tests repo

@fselmo
Copy link
Contributor

fselmo commented Jan 27, 2025

If I understand correctly, moving the current state of ethereum/tests into /LegacyTests as the submodule and having the branches in ethereum/tests transition to static EEST-filled json files would allow consumers to pull from both EEST and ethereum/tests jsons with one git tag as the version.

I think this would be ideal, at least while conversion of the legacy tests to EEST is still in progress. Unless there's a better way that I'm not seeing to ensure full test coverage for consumers during the transition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants