Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API refactor #120

Closed
yorickdowne opened this issue Aug 29, 2024 · 2 comments
Closed

API refactor #120

yorickdowne opened this issue Aug 29, 2024 · 2 comments

Comments

@yorickdowne
Copy link

yorickdowne commented Aug 29, 2024

From ethereum#408

“The API is full of inconsistent type usage, some numbers are hex encoded, others are not, some are strings, some are not, ...

It would be great if future API versions could transition to use the proper hexutil types where appropriate and thereby getting rid of this mess.

Originally posted by @Nichebiche in https://github.com/flashbots/mev-geth/issues/145#issuecomment-2185621606”

Would be good to have this done before audit in October.

This sounds like a breaking change. If we go for it, we may consider a version 3.x right after audit, to signal that we are breaking API from upstream 2.x

@yorickdowne
Copy link
Author

This appears to be nonsense, or at least not related to staking-deposit-cli at all

flashbots/mev-geth#145 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@yorickdowne and others