Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsynced status of DownsamplingScheduler #497

Open
XianzheMa opened this issue Jun 12, 2024 · 1 comment
Open

Fix unsynced status of DownsamplingScheduler #497

XianzheMa opened this issue Jun 12, 2024 · 1 comment
Assignees

Comments

@XianzheMa
Copy link
Collaborator

As we have multiple selector instances, the status of DownsamplerScheduler, i.e. which sampler is currently applied and which one should be used next, is out of sync. We should fix this.

Relevant PR: #496 (review)

@XianzheMa
Copy link
Collaborator Author

Actually, I want to completely remove the DownsamplingScheduler, as we also have never used it in experiments.

I think the design of DownsamplingScheduler, i.e. hard-code specifying "from trigger 3 to trigger 7, I want to use Downsampler X" by a user is hardly practical as the user cannot predict it in advance. We might want to have a more sophisticated scheduler based on data distribution, but this is out of scope for now.

What do you think @MaxiBoether ?

@XianzheMa XianzheMa self-assigned this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant