Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename scripts' modules_exp to modules_for_bom #18602

Closed
ivanvc opened this issue Sep 18, 2024 · 2 comments · Fixed by #18603
Closed

Rename scripts' modules_exp to modules_for_bom #18602

ivanvc opened this issue Sep 18, 2024 · 2 comments · Fixed by #18603

Comments

@ivanvc
Copy link
Member

ivanvc commented Sep 18, 2024

What would you like to be added?

This is a follow-up on #18590 (comment). Currently, the function modules_exp defined in scripts/test_lib.sh is serving the only purpose of providing a list of modules for verifying and fixing the bill of materials (BOM).

etcd/scripts/test_lib.sh

Lines 199 to 203 in e094139

function modules_exp() {
for m in $(modules); do
echo -n "${m}/... "
done
}

We should rename it from modules_exp to modules_for_bom for clarity and update the two instances where it is referenced:

  1. scripts/test.sh:

    etcd/scripts/test.sh

    Lines 508 to 512 in 4f9cd33

    function bom_pass {
    log_callout "Checking bill of materials..."
    # https://github.com/golang/go/commit/7c388cc89c76bc7167287fb488afcaf5a4aa12bf
    # shellcheck disable=SC2207
    modules=($(modules_exp))
  2. scripts/updatebom.sh:
    modules=($(modules_exp))

Why is this needed?

To improve the code and clarity of the helper functions from the build and test scripts.

@ivanvc
Copy link
Member Author

ivanvc commented Sep 19, 2024

/assign @lekaf974

@k8s-ci-robot
Copy link

@ivanvc: GitHub didn't allow me to assign the following users: lekaf974.

Note that only etcd-io members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @lekaf974

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants