You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a follow-up on #18590 (comment). Currently, the function modules_exp defined in scripts/test_lib.sh is serving the only purpose of providing a list of modules for verifying and fixing the bill of materials (BOM).
@ivanvc: GitHub didn't allow me to assign the following users: lekaf974.
Note that only etcd-io members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
What would you like to be added?
This is a follow-up on #18590 (comment). Currently, the function
modules_exp
defined inscripts/test_lib.sh
is serving the only purpose of providing a list of modules for verifying and fixing the bill of materials (BOM).etcd/scripts/test_lib.sh
Lines 199 to 203 in e094139
We should rename it from
modules_exp
tomodules_for_bom
for clarity and update the two instances where it is referenced:scripts/test.sh
:etcd/scripts/test.sh
Lines 508 to 512 in 4f9cd33
scripts/updatebom.sh
:etcd/scripts/updatebom.sh
Line 15 in 4f9cd33
Why is this needed?
To improve the code and clarity of the helper functions from the build and test scripts.
The text was updated successfully, but these errors were encountered: