Add `augerctl` like kubectl #62

wzshiming · 2024-05-22T08:57:55Z

Fixes #3

Test

Preparation cluster

Create a cluster and expose etcd port, to facilitate the creation of a cluster using kwokctl, this can be any other k8s cluster

# brew install kwok
kwokctl create cluster --etcd-port 2379

Get a single resource

Get the kubernetes.default service

go run ./cmd/augerctl get services -n default kubernetes

Get the all of the resource

go run ./cmd/augerctl get leases -n kube-system

Get the all of the etcd

go run ./cmd/augerctl get

Modify immutable data

# change the creation time to very long ago
go run ./cmd/augerctl get services -n default kubernetes | sed 's/creationTimestamp: .*/creationTimestamp: "2006-01-02T15:04:05Z"/' | go run ./cmd/augerctl put --path -
kubectl get services -n default kubernetes

Maybe patch subcommands can be added in the future

Delete data

go run ./cmd/augerctl del services -n default kubernetes

cmd/ctl/main.go

pkg/ctl/command/get/get.go

pkg/ctl/command/get/global.go

pkg/ctl/ctl.go

wzshiming · 2024-05-22T09:31:47Z

/assign @jmhbnz
/assign @siyuanfoundation

This PR is expected to add a subcommand like kubectl to manipulate etcd data, do you guys have time to take a look at it and leave suggestions and comments to guide this forward?

pkg/ctl/command/global.go

cmd/ctl/main.go

wzshiming · 2024-07-19T16:25:11Z

Hi @jmhbnz @siyuanfoundation

Is it out of scope?
So I'm alternatively planning to make this a separate project, would it be OK to call it augerctl or kectl(Kubernetes Etcd ctl)?

siyuanfoundation · 2024-07-21T16:07:46Z

I think it's a good idea. 'augerctl' sounds good.

Can you break up the PR to smaller pieces so that they are easier to review?

Thank you!

k8s-ci-robot · 2024-07-22T03:04:15Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wzshiming
Once this PR has been reviewed and has the lgtm label, please ask for approval from jmhbnz. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wzshiming · 2024-07-22T03:37:29Z

Ahhh, I don't know how much more this can be split, it's already the smallest possible implementation of the tool.
I understand your concern that this merge will mess up the current codebase.
So I create a new repo https://github.com/wzshiming/kectl, and make it stable, and then propose it to the sig-etcd.
WDYT?

siyuanfoundation · 2024-07-22T16:35:26Z

Ahhh, I don't know how much more this can be split, it's already the smallest possible implementation of the tool. I understand your concern that this merge will mess up the current codebase. So I create a new repo https://github.com/wzshiming/kectl, and make it stable, and then propose it to the sig-etcd. WDYT?

Examples of how to breaking up the PR could be

1 PR for get
1 PR for delete
...

Yes, I think the idea could be worth discussing in sig-etcd meeting.

wzshiming · 2024-07-27T12:13:48Z

Ahhh, I don't know how much more this can be split, it's already the smallest possible implementation of the tool. I understand your concern that this merge will mess up the current codebase. So I create a new repo https://github.com/wzshiming/kectl, and make it stable, and then propose it to the sig-etcd. WDYT?

Examples of how to breaking up the PR could be

1 PR for get

1 PR for delete

...

I've created a new PR for the get and removed optional features. #82

Signed-off-by: Shiming Zhang <[email protected]>

jmhbnz · 2024-08-14T00:42:01Z

Closed in favor of #82

k8s-ci-robot added the do-not-merge/work-in-progress label May 22, 2024

wzshiming force-pushed the feat/kubectl-like branch from 48e82b7 to 0d14d24 Compare May 22, 2024 09:00