Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARP checking not testing for it's own IP (IDFGH-11117) #60

Closed
phildimond opened this issue Sep 22, 2023 · 2 comments
Closed

ARP checking not testing for it's own IP (IDFGH-11117) #60

phildimond opened this issue Sep 22, 2023 · 2 comments
Assignees

Comments

@phildimond
Copy link

if (ip4_addr_cmp(addr, &dhcp->offered_ip_addr)) {

Device responds to it's own ARP check, detects itself and then rejects the ip address offered for DHCP. The device should check that the respondent's MAC is not it's own or (better) disable ARP responses before the check and re-enable afterward.

@github-actions github-actions bot changed the title ARP checking not testing for it's own IP ARP checking not testing for it's own IP (IDFGH-11117) Sep 22, 2023
@espressif-abhikroy
Copy link
Collaborator

If the device already have an IP address, the ip4_addr_cmp() function should not be executed due to the preceding check:

  /* Is a DHCP client performing an ARP check? */
  if ((dhcp != NULL) && (dhcp->state == DHCP_STATE_CHECKING)) {

In this scenario, any ARP reply should be discarded.

If you have a different observation, kindly provide details about your network setup and all relevant logs.

@david-cermak
Copy link
Collaborator

feel free to reopen with more details/comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants