-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stable driver: GPIO #2492
Labels
Comments
This was referenced Nov 8, 2024
Closed
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Dec 2, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Closed
MabezDev
assigned bugadani, playfulFence, jessebraham and SergioGasquez and unassigned MabezDev, bugadani and playfulFence
Dec 6, 2024
Deleted it from this list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As part of #2491, which has more details on driver analysis.
esp-hal API-GUIDELINE omissions
InputConnection
instead ofPeripheralInput
#2658Event
,WakeEvent
,Level
,Pull
,DriveStrength
&AlternateFunction
are missing#[non_exaustive]
#2694Event
,WakeEvent
,Level
,Pull
,DriveStrength
&AlternateFunction
are missing derives #2695Config
struct instead ofPull
orLevel
directly. #2696crate::any_peripheral
to define the "any" peripheral instance type. #2707Result<Self, ConfigError>
#2708crate::Mode
type parameter. #2709&mut self
when&self
is safe to use. #2711peripheral::subcategory
module. #2712Rust API guideline ommissions
C-COMMON-TRAITS
GPIO: Implement common traits #2664unwrap()
inbind_default_interrupt_handler()
andset_interrupt_priority()
Double check usage of unwrap / panic #2657C-FAILURE
: GPIO:C-FAILURE
violation #2665C-HIDDEN
violations #2697C-CUSTOM-TYPE
: GPIO:C-CUSTOM-TYPE
#2715Hardware feature omissions
Mode/features of the driver that are lacking
Output
,Input
and others that wrapFlex
should be#[repr(transparent)]
#2698Misc
init_output
the condition to include the call todisable_usb_pads
should be#[cfg(usb_device)]
The text was updated successfully, but these errors were encountered: