Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-72: Update .gitignore #84

Closed
wants to merge 1 commit into from
Closed

ISSUE-72: Update .gitignore #84

wants to merge 1 commit into from

Conversation

aksm
Copy link
Contributor

@aksm aksm commented Oct 6, 2022

Continuing to resolve #72.

Added drupal/composer.json because we do cp ../../drupal/composer.default.json ../../drupal/composer.json so that local change should be ignored.

@DiegoPino
Copy link
Member

@aksm you sure? That was question for discussion really because we do want people to be able to commit their composer.json?
Also what about

We still need to make sure we exclude the default.settings/default.services php and YML files bc Drupal sometimes creates new ones for those and a few more
I added as a comment in the original ISSUE? I think we need to have a larger discussion of this next week maybe? On our Monday call?

@aksm
Copy link
Contributor Author

aksm commented Oct 6, 2022

@DiegoPino Sorry, I just realized the same right after I made this PR. And re: the default.settings/default.services etc., I started working on that but forgot to commit and got distracted. Will keep working on this.

@DiegoPino
Copy link
Member

Let's close this one for now. Pretty sure we are not sure how this will affect running Systems!

@DiegoPino DiegoPino closed this Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update .gitignore
2 participants