Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate stripe to use URLSearchParams #3

Open
43081j opened this issue Jan 27, 2024 · 1 comment
Open

migrate stripe to use URLSearchParams #3

43081j opened this issue Jan 27, 2024 · 1 comment
Labels
has pr This issue has a corresponding PR in the target repo pr needs update The PR in the target repo has gone stale and needs to be rebased

Comments

@43081j
Copy link
Collaborator

43081j commented Jan 27, 2024 •
edited
Loading

The stripe node package can be found here:
https://github.com/stripe/stripe-node

it supports node >12 which should mean we can safely move to using URLSearchParams instead of the qs package.

We should contribute upstream for this one.

Note that stripe uses nested query string parameters (i.e. they have keys like foo[bar][baz]=123). So we should probably use fast-querystring or nested-querystring
@43081j 43081j added the help wanted Extra attention is needed label Jan 27, 2024
@talentlessguy
Copy link

Seems like the PR is already here: stripe/stripe-node#2116

@43081j 43081j added waiting for upstream and removed help wanted Extra attention is needed labels Jun 29, 2024
@Fuzzyma Fuzzyma added has pr This issue has a corresponding PR in the target repo pr needs update The PR in the target repo has gone stale and needs to be rebased and removed waiting for upstream labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has pr This issue has a corresponding PR in the target repo pr needs update The PR in the target repo has gone stale and needs to be rebased
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Fuzzyma @43081j @talentlessguy