Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserved identifier violation #7

Open
elfring opened this issue Oct 15, 2017 · 3 comments
Open

reserved identifier violation #7

elfring opened this issue Oct 15, 2017 · 3 comments
Assignees

Comments

@elfring
Copy link

elfring commented Oct 15, 2017

I would like to point out that identifiers like “_STRING_BUILDER_H_” and “_VMCODE_H_do not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?

@eriknyquist
Copy link
Owner

interesting, had not heard of that. Thanks for the recommendation

@eriknyquist
Copy link
Owner

fixed
8f04d21

@elfring
Copy link
Author

elfring commented Oct 18, 2017

Thanks for your adjustment of affected include guards.

I would appreciate if these identifiers will not only become standard compliant but also safe for reuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants