Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with native Firefox shortcut for taking screenshots #139

Open
FreeYourMinds opened this issue Nov 30, 2024 · 8 comments
Open

Conflict with native Firefox shortcut for taking screenshots #139

FreeYourMinds opened this issue Nov 30, 2024 · 8 comments

Comments

@FreeYourMinds
Copy link

FreeYourMinds commented Nov 30, 2024

Issue

Can not invoke the shortcut for Tabhunter on Windows

Reason

Ctrl-Shift-S is Firefox native shortcut for taking a screenshot on Windows -> Firefox Screenshots

Also, I cannot change TabHunters shortcut in the settings, but from my understanding this seem to be per design?

Steps To Reproduce

Try invoking TabHunters shortcut in Firefox on Windows

@ericpromislow
Copy link
Owner

No, it's just that no one on the team has found time to work on this

@FreeYourMinds
Copy link
Author

I see, so there is currently no way of invoking TabHunter on Windows per hotkey.

Wouldn't it be an option to just change the default key binding for now?

@ericpromislow
Copy link
Owner

Right now no one on the "team" has a Windows development machine. Only macOS and linux. But the source code is right here and anyone is welcome to contribute.

@FreeYourMinds
Copy link
Author

FreeYourMinds commented Dec 17, 2024

@ericpromislow as you wish PR #141

Note:

As I do not have a Ruby dev environment nor are there any instructions on how to set up a dev environment for windows, this is an untested change! I have only verified that the new shortcut is not taken by any others on windows per default. But as this is only a change in the manifest, I considered it an acceptable risk

@unleashed7
Copy link

You can change the shortcut in Extensions > Manage Extension Shortcuts to a different key.

@FreeYourMinds
Copy link
Author

FreeYourMinds commented Jan 2, 2025

You can change the shortcut in Extensions > Manage Extension Shortcuts to a different key.

Sadly you can not. That is part of the problem. Any Change is neither applied nor persisted.

@unleashed7
Copy link

Not sure what the issue is on your end, for me it works without a problem. Tried changing it to Ctrl+Shift+F and Ctrl+Shift+Space just to test and it opens with that hotkey.

2025-01-03.01-05-49.mp4

@FreeYourMinds
Copy link
Author

Not sure what the issue is on your end, for me it works without a problem. Tried changing it to Ctrl+Shift+F and Ctrl+Shift+Space just to test and it opens with that hotkey.
2025-01-03.01-05-49.mp4

Interesting, you were right, it is on my side. Using a fresh profile, this does work 👍
Nevertheless, I would still change the default shortcut to something that is not in conflict with a native Firefox one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants