Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CryptoFacade.exponentiatePoint and CryptoFacade.multiplyPoints #876

Open
kushti opened this issue Apr 23, 2023 · 0 comments · May be fixed by #948
Open

Rename CryptoFacade.exponentiatePoint and CryptoFacade.multiplyPoints #876

kushti opened this issue Apr 23, 2023 · 0 comments · May be fixed by #948
Labels
C-enhancement Category: A PR with an enhancement or a proposed one in an issue. P3-low Priority: Low
Milestone
v5.x

Comments

@kushti
Copy link
Member

kushti commented Apr 23, 2023

For example, Autolykos v1 PoW check now contains following code

    val left = CryptoFacade.exponentiatePoint(s.w, f.bigInteger)
    val right = CryptoFacade.multiplyPoints(
      CryptoFacade.exponentiatePoint(group.generator, s.d.bigInteger),
      s.pk)

A group has operations to multiply elements and exponentiate an element of a group. For elliptic curve points additive notation is used everywhere

Thus operations should be renamed, exponentiatePoint => exponentiateElement, multiplyPoints => multiplyElements
@kushti kushti mentioned this issue Apr 23, 2023
Merged
@aslesarenko aslesarenko added this to the v5.x milestone Apr 25, 2023
@aslesarenko aslesarenko added C-enhancement Category: A PR with an enhancement or a proposed one in an issue. P3-low Priority: Low labels Apr 25, 2023
@jozanek jozanek linked a pull request Jan 12, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: A PR with an enhancement or a proposed one in an issue. P3-low Priority: Low
Projects
None yet
Milestone
v5.x
Development

Successfully merging a pull request may close this issue.

Rename point to element in CryptoFacade jozanek/sigmastate-interpreter
2 participants
@aslesarenko @kushti