Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up xtgeo.metadata.metadata into per-object submodules #1155

Open
mferrera opened this issue Feb 9, 2024 · 0 comments
Open

Split up xtgeo.metadata.metadata into per-object submodules #1155

mferrera opened this issue Feb 9, 2024 · 0 comments
Labels
refactor Code improvements (~invisible for users)

Comments

@mferrera
Copy link
Contributor

mferrera commented Feb 9, 2024

Currently metadata objects for all xtgeo objects are kept in the xtgeo.metadata.metadata module. This module needs access to all the major xtgeo types to do instance checking which complicates the dependency chain.

For example, a RegularSurface needs the MetaDataRegularSurface object from xtgeo.metadata.metadata to store in RegularSurface._metadata. Thus the dependency chain looks like this

RegularSurface <- xtgeo.metadata.metadata <- Cube, Grid, Well, etc... <- RegularSurface
                             ^________________<_________________<______________v

The MetaData objects in xtgeo.metadata should be split either into their own submodules within the metadata package, or parceled out to the objects they represent respectively.

Not clear if the metadata package is relied upon elsewhere, but I don't think it is.

@mferrera mferrera added the refactor Code improvements (~invisible for users) label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code improvements (~invisible for users)
Projects
None yet
Development

No branches or pull requests

1 participant