CLN: Remove bare xtgeo imports #1161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cannot be enforce through current ruff rules so flag it in CI.
Enforce that pandas and numpy are imported as pd and np, respectively, and also that some modules must be lazily imported. This will make enforcing lazy imports for heavier packages easier later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1149
I was a bit opinionated with these changes in expanding import paths fully and using relative imports, but I don't particularly believe that needs to be enforced and no linting rules exist to enforce it anyway. I do think that it will be a bit helpful in the near term, with structural refactors ahead, and that we should discuss whether or not to codify it in the style guide. Some major projects, e.g. pandas, do this.
This also adds a manual check in linting ci to make sure no further
import xtgeos are added