Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new Dialog component #261

Closed
jorgenherje opened this issue Sep 20, 2022 · 0 comments · Fixed by #275
Closed

Create new Dialog component #261

jorgenherje opened this issue Sep 20, 2022 · 0 comments · Fixed by #275
Assignees
Labels
enhancement New feature or request

Comments

@jorgenherje
Copy link
Collaborator

Create new Dialog component for wcc.

The current Dialog component is implemented by use of MaterialUI and has issues when it comes to have multiple dialogs open simultaneously. The dialog opens on top, placed on top with backdrop and higher z-index than the previously opened dialog. This prevents interaction with the dialogs opened prior to the last opened dialog. Thereby one cannot ensure interaction with multiple dialogs opened at the same time. The dialog is placed deep within parent structure in DOM and thus it is hard to control z-index and correct behavior.

The content can also trigger scroll area, rather than placing the content on top. E.g. when using a dropdown, the suggestions list does not appear on top, but triggers scroll area for the dialog.

Resolves:


TODO:

  • Make dialog component for handling multiple dialogs at the same time
  • Create dialogs placed at body-level
  • Control using class names: Dialog, DialogActive, DialogModal
  • Control content to be on top, prevent scrollable area. E.g. suggestions for a dropdown opens on top/overflow

Examples on issues:

When opening the settings dialog on the right first, the settings dialog on the left is on top with overlay. Thereby one cannot interact with the dropdown in the right hand side dialog.

image

When opening the dropdown suggestions for the dialog content, the scroll area of the dialog triggers. Goal is to place content on top and obtain a overflow-like behavior. Issue with overflow is shown below.

image

NOTE: Issue with overflow: visible of the current Dialog paper component is that content is shown when re-sizing window smaller than the original content.
image
image

@jorgenherje jorgenherje added the enhancement New feature or request label Sep 20, 2022
@jorgenherje jorgenherje self-assigned this Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done 🏁
Development

Successfully merging a pull request may close this issue.

1 participant