Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Let NginX serve the static files generated by Node.js #203

Open
sindre-nistad opened this issue Mar 14, 2023 · 2 comments
Open

Comments

@sindre-nistad
Copy link
Contributor

Describe Problem

Currently, (the web server) NginX does not host any of the static files generated by Node.js.

Suggest Changes

My suggestion, is to let NginX host all static files, and remove the web container for the production environment

Provide Examples

I've done something similar in a different project.
I can provide a PR if that is desired.

@olavis
Copy link
Contributor

olavis commented Mar 15, 2023

@sindre-nistad Related to #51?

@sindre-nistad
Copy link
Contributor Author

@sindre-nistad Related to #51?

I don't think so? #51 seem related to the publishing of the NginX image, while this is suggesting removing the need for the web container in prod.
It will still be necessary when developing locally (hor reloading and such), but it should reduce the number of dependencies (e.g. serve), and potentially make the loading of the site a little quicker (fewer hops on the server / hosting environment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants