Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 📦 Add design tokens for spacing #148

Open
Blubtastic opened this issue Nov 14, 2022 · 0 comments
Open

refactor: 📦 Add design tokens for spacing #148

Blubtastic opened this issue Nov 14, 2022 · 0 comments
Assignees
@Blubtastic
Labels
type: :neckbeard: refactor

Comments

@Blubtastic
Copy link
Collaborator

Blubtastic commented Nov 14, 2022 •
edited
Loading

Describe Problem

The longer hardcoded values are used for designing the user interface, the harder it will be to maintain. Cooperation between designers and developers will also be harder, as there are no common way of communicating visual details.

Suggest Solution

Implement design tokens based on the EDS design system

Once these have been added, create a new PR for replacing all hardcoded spacing with these tokens.
@Blubtastic Blubtastic self-assigned this Nov 14, 2022
@Blubtastic Blubtastic changed the title Design tokens for spacing style: 💎 Design tokens for spacing Nov 14, 2022
@Blubtastic Blubtastic changed the title style: 💎 Design tokens for spacing refactor: 📦 Design tokens for spacing Nov 14, 2022
@Blubtastic Blubtastic changed the title refactor: 📦 Design tokens for spacing refactor: 📦 Add design tokens for spacing Nov 14, 2022
@Blubtastic Blubtastic mentioned this issue Nov 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Blubtastic Blubtastic

Labels
type: :neckbeard: refactor
Projects
Development
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Blubtastic