Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mlflow report example notebook #905

Closed
wants to merge 1 commit into from

Conversation

ryanjdillon
Copy link
Contributor

@ryanjdillon ryanjdillon commented Jan 31, 2020

Added the example notebook for querying with the MlFlow client with updates for using the reporters.

closes #861

@ryanjdillon
Copy link
Contributor Author

@flikka Do you have any notes you think we should add for the AzureML sdk?

@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #905 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
+ Coverage   93.37%   93.46%   +0.09%     
==========================================
  Files          62       62              
  Lines        2973     2969       -4     
==========================================
- Hits         2776     2775       -1     
+ Misses        197      194       -3
Impacted Files Coverage Δ
gordo/reporters/mlflow.py 100% <100%> (+2.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e73b3ec...4a8efa8. Read the comment docs.

examples/Gordo-Reporters-MlFlow.ipynb Outdated Show resolved Hide resolved
@ryanjdillon ryanjdillon force-pushed the add_mlflow_example branch 6 times, most recently from d60b618 to d0c7fd1 Compare February 12, 2020 08:32
@flikka
Copy link
Contributor

flikka commented Feb 20, 2020

@ryanjdillon closed it?

@ryanjdillon ryanjdillon reopened this Feb 24, 2020
@ryanjdillon ryanjdillon force-pushed the add_mlflow_example branch 6 times, most recently from 8bbd2bb to 81d5085 Compare February 25, 2020 09:42
Copy link
Contributor

@flikka flikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a part from the real tags which should be "anonymized" (change the numbers/letters a bit?)

examples/Gordo-Reporters-MlFlow.ipynb Outdated Show resolved Hide resolved
@ryanjdillon ryanjdillon force-pushed the add_mlflow_example branch 2 times, most recently from 456ab51 to 0483f35 Compare February 26, 2020 13:04
  * Change get_kwargs method to return an empty dict if the secrets
    environment variable missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add notebook that demos Mlflow querying
4 participants