Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_smry_stats() behaviour on uneven end-date. #209

Open
berland opened this issue Mar 18, 2021 · 0 comments
Open

get_smry_stats() behaviour on uneven end-date. #209

berland opened this issue Mar 18, 2021 · 0 comments
Milestone

Comments

@berland
Copy link
Collaborator

berland commented Mar 18, 2021

fmu.ensemble 1.0 ensured an ensemble-wide common timegrid for get_smry_stats(), but in 2.0, this is no longer so, realizations can end at any time, and get_smry(time_index='monthly') is not guaranteed to give the same ending month for every realization.

This is fine for ensemble plotting, but for statistics it is not so easy.

get_smry_stats() has two choices when dealing with uneven end-dates:

  • Ignore it, and let pandas handle it through groupby('DATE'). This gives a discontinuity in the mean at dates where a realization stops to exist.
  • Ensure a common end-date, and extrapolate rates as zeros, and cumulatives as constants.

If the realization has crashed unintentionally (Eclipse bug etc.) both of these are wrong, and the user must solve the problem by filtering out the entire failed realization.

Since real failures should be filtered out, get_smry_stats() may assume that the premature end-date of a realization is intentional from the user, and then the correct way to handle it is to extrapolate rates as zero etc. Correct extrapolation is provided by libecl, which means that either get_smry_stats() must call get_smry() once more with an end-date set, or extrapolate using ad-hoc pandas code (using metadata to find cumulatives/rates).

@berland berland added this to the 2.0 milestone Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant