Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name input is not checked against alias list #853

Open
tnatt opened this issue Oct 17, 2024 · 0 comments
Open

name input is not checked against alias list #853

tnatt opened this issue Oct 17, 2024 · 0 comments

Comments

@tnatt
Copy link
Collaborator

tnatt commented Oct 17, 2024

Currently the only time fmu-dataio will convert data.name to the stratigraphic name is if the name input is defined as key in the stratigraphy block in the config. Should it not also check if the name is within any alias list, and then do the conversion? What is the purpose of the alias list if not? It is added as metadata, but it doesn't seem very usable in the current state.

e.g.

stratigraphy:
  TopVolantis:
    stratigraphic: true
    name: VOLANTIS GP. Top
    alias:
    - TopVOLANTIS
    - TOP_VOLANTIS

and exporting a surface with name="TopVOLANTIS" will produce metdata with data.name="TopVOLANTIS" and stratigraphic=False but should rather be data.name="VOLANTIS GP. Top" and stratigraphic=True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant