Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Consider (!) dedicated link to stratigraphic column #851

Open
perolavsvendsen opened this issue Oct 16, 2024 · 1 comment
Open

ENH: Consider (!) dedicated link to stratigraphic column #851

perolavsvendsen opened this issue Oct 16, 2024 · 1 comment

Comments

@perolavsvendsen
Copy link
Member

Currently, each data object which represents a stratigraphic entity (horizon, zone) is linked to the stratigraphic column via data.name. Since the "name" of an object within FMU can be completely arbitrary, we use a lookup function which matches "FMU-name" with "Official name", and replaces. In the stratigraphic column, then name is the identifier.

Example:

In global_variables:

stratigraphy:
  Viking_Top:
    name: VIKING Gp. Top

When exporting e.g. a surface representing "Viking Top", the name will initially be "Viking_Top". We do a lookup in stratigraphy, and if "Viking_Top" is found, we replace the name with the official one. Resulting metadata looks like this:

data:
  name: VIKING Gp. Top
  stratigraphic: true

Similarly, if we export "Some Other Name" which is NOT in the stratigraphy dictionary, resulting metadata becomes:

data:
  name:  Some Other Name
  stratigraphic: false

Meanwhile, other references to master data sits in the masterdata block, e.g.

masterdata:
  smda:
    field: ...
    stratigraphic_column: ...

Suggestion for discussion

Instead of using data.name as the identifier, we use an explicit one. I.e. we create something like:

masterdata:
  smda:
    stratigraphic_column: <uuid4> # id of the strat column in SMDA
    stratigraphic_entity:
      identifier: <Name of the Horizon> # 🆕

This may be easier to both understand and use further. It is not a great pattern than we have a bool ("stratigraphic") which determines if data.name is an actual identifier, or just a string.

@tnatt
Copy link
Collaborator

tnatt commented Oct 17, 2024

related #401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants