Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export_fault_lines() one liner export #763

Open
3 tasks
mferrera opened this issue Aug 22, 2024 · 2 comments
Open
3 tasks

Add export_fault_lines() one liner export #763

mferrera opened this issue Aug 22, 2024 · 2 comments

Comments

@mferrera
Copy link
Collaborator

mferrera commented Aug 22, 2024

Currently fault polygons are exported from RMS projects in the following way:

  • Specify the horizon names
  • Specify a folder, under the assumption this folder exists for each horizon
  • Loop through each horizon, and if that folder is there and not empty,
    • Create an xtgeo.Polygon from the RMS polygon
    • Create an ExportData instance for each file format being exported
    • Set the polygon fileformat
    • Export

Simplification

A possible one-liner export could instead look something like this:

for category_name in HORIZON_NAMES:
    export_fault_lines(
        project: Any, 
        category_name: str,
        vertical_domain: str = "depth",  # or "time"
        config_path: str | Path = "../../fmuconfig/output/global_variables.yml",
        classification: str | None = None, # Actual default from config
    )

This means we will provide defaults for tagname, name, and workflow (and anything else not listed). This provides a good substrate to accomplish standardization and guide assets to conforming to a single way of doing it, while also allowing an escape hatch of using ExportData directly to deviate from them.

TODO

  • How should we structure the aforementioned defaulted values (tagname, name, workflow)?

Tasks

@mferrera
Copy link
Collaborator Author

Consider naming this fault_lines over fault_polygons to prefer the data product over the data type.

@mferrera mferrera changed the title Add export_fault_polygons() one liner export Add export_fault_lines() one liner export Aug 23, 2024
@mferrera
Copy link
Collaborator Author

Sept 25 2024 - updated root comment with refinement from discussions and removing the list of unanswered questions as we have now mostly answered them. This is now approaching "final".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant