Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out why checking robot.model.type fixes it being null #1661

Open
oysand opened this issue Jul 1, 2024 · 3 comments
Open

Figure out why checking robot.model.type fixes it being null #1661

oysand opened this issue Jul 1, 2024 · 3 comments
Labels
bug Something isn't working stale This issue or pull request already exists

Comments

@oysand
Copy link
Contributor

oysand commented Jul 1, 2024

Describe the bug
When isar finished the mission the screen turned white and it complained that type was null. After reproducing it locally the following check #1659 was added during debugging and then the problem dissapeared.

To Reproduce
Steps to reproduce the behavior:

  1. Connect to the dev database locally.
  2. Revert Check if updated robot model is null #1659
  3. Run a mission and observe what happens when the mission completes

Expected behavior
Would like some other fix than just doing an if check

Screenshots
If applicable, add screenshots to help explain your problem.

@oysand oysand added the bug Something isn't working label Jul 1, 2024
@oysand
Copy link
Contributor Author

oysand commented Jul 1, 2024

Connected to #1537

@Eddasol Eddasol changed the title Figure out why checking robot.model.type fixes it being null Fix root cause of robot.model.type becoming null Jul 1, 2024
@oysand oysand changed the title Fix root cause of robot.model.type becoming null Figure out why checking robot.model.type fixes it being null Jul 1, 2024
@oysand
Copy link
Contributor Author

oysand commented Jul 1, 2024

The if check never true, but checking the value makes the system investigate the value and stops it from being treated as null further down the line.

@aeshub
Copy link
Contributor

aeshub commented Aug 31, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants