From 5b523613e936d7d88c52c23916e98c49914d66a4 Mon Sep 17 00:00:00 2001
From: "R.Sicart" <roger.sicart@gmail.com>
Date: Mon, 15 Apr 2024 15:01:53 +0200
Subject: [PATCH] fix(k8s): Deployment.strategy is independent of
 deploymentType

When unset, k8s defaults are the following:

rollingUpdate:
  maxSurge: 25%
  maxUnavailable: 25%

Currently, the same values are set when deploymentType is "deployment".

After merging this patch, defaults will be the same, but we'll be able
to override them independently of deploymentType.
---
 templates/deployment.yaml | 2 --
 values.yaml               | 3 +++
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/templates/deployment.yaml b/templates/deployment.yaml
index 4f3564c..cfc55ba 100644
--- a/templates/deployment.yaml
+++ b/templates/deployment.yaml
@@ -16,12 +16,10 @@ spec:
   selector:
     matchLabels:
       {{- include "krakend.selectorLabels" . | nindent 6 }}
-  {{- if eq .Values.deploymentType "rollout" }}
   {{- with .Values.strategy }}
   strategy:
     {{- toYaml . | nindent 4 }}
   {{- end }}
-  {{- end }}
   template:
     metadata:
       annotations:
diff --git a/values.yaml b/values.yaml
index 094d478..ab779d8 100644
--- a/values.yaml
+++ b/values.yaml
@@ -19,6 +19,9 @@ deploymentType: deployment
 # a `deployment` or a `rollout` strategy.
 # For more information on the Argo Rollout strategy, see https://argo-rollouts.readthedocs.io/en/stable/features/specification/
 strategy: {}
+#  rollingUpdate:
+#    maxSurge: 25%
+#    maxUnavailable: 10%
 
 krakend:
   # -- (bool) Whether the given krakend image to be used contains everything needed