-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config documentation is a bit convoluted #158
Labels
documentation
Improvements or additions to documentation
Comments
Agreed. Let's tackle this after #157. |
epwalsh
added a commit
that referenced
this issue
Jul 25, 2023
Addressed by 2c2a368. |
Addressed by #161. |
Addressed by 6e2af3d. |
flaviosakakibara
pushed a commit
to flaviosakakibara/obsidian.nvim
that referenced
this issue
Sep 5, 2023
…h#178) Closes epwalsh#175 Closes epwalsh#177 Closes epwalsh#173 Closes epwalsh#169 Closes epwalsh#161 Closes epwalsh#144 Closes epwalsh#138 Fixes epwalsh#136 Closes epwalsh#137 Closes epwalsh#131 Closes epwalsh#117 Closes epwalsh#130 Closes epwalsh#115 Closes epwalsh#86 Closes epwalsh#105 Closes epwalsh#70 Fixes epwalsh#176 Fixes epwalsh#174 Fixes epwalsh#160 Fixes epwalsh#158
Closed as completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
📚 The doc issue
Currently, configuration information may be found in three different places,
Install and Configure/Lazy.nvim
,Install and Configure/packer
, andConfiguration Options
. Also, the installation code example for Lazy.nvim only is the only place to find information about dependencies.These are a handful of larger changes that I thought might warrant some discussion as opposed to the small ones I submitted a PR for earlier.
Suggest a potential alternative/fix
Move dependency information to its own section and remove it from the Lazy.nvim setup, assuming users know how their package managers work. This will drastically cut down on the size of the Lazy.nvim setup portion and add emphasis to the configuration portion.
Remove keybinding recommendation from Lazy.nvim setup, moving either to a system I proposed in Make
gf
keybinding a part of the config #157, or to its own keybinding section as a subheader of the Configuration section. This keybind may be skipped over as its part of the installation section and it feels like it belongs in a different place anyway. This will also help to shorten the section.Configuration about templates seems to be partially duplicated. Seems intentional but it's worth taking a think about as it adds some extra clutter and makes the config section difficult to scan quickly.
Treesitter markdown additional vim regex highlighting is recommended but it's unclear the effect it will have. We should probably add some comparison pictures to make it more clear.
The text was updated successfully, but these errors were encountered: