Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config documentation is a bit convoluted #158

Closed
shakesbeare opened this issue Jul 22, 2023 · 5 comments
Closed

Config documentation is a bit convoluted #158

shakesbeare opened this issue Jul 22, 2023 · 5 comments
Labels
documentation Improvements or additions to documentation

Comments

@shakesbeare
Copy link
Contributor

📚 The doc issue

Currently, configuration information may be found in three different places, Install and Configure/Lazy.nvim, Install and Configure/packer, and Configuration Options. Also, the installation code example for Lazy.nvim only is the only place to find information about dependencies.

These are a handful of larger changes that I thought might warrant some discussion as opposed to the small ones I submitted a PR for earlier.

Suggest a potential alternative/fix

  1. Move dependency information to its own section and remove it from the Lazy.nvim setup, assuming users know how their package managers work. This will drastically cut down on the size of the Lazy.nvim setup portion and add emphasis to the configuration portion.

  2. Remove keybinding recommendation from Lazy.nvim setup, moving either to a system I proposed in Make gf keybinding a part of the config #157, or to its own keybinding section as a subheader of the Configuration section. This keybind may be skipped over as its part of the installation section and it feels like it belongs in a different place anyway. This will also help to shorten the section.

  3. Configuration about templates seems to be partially duplicated. Seems intentional but it's worth taking a think about as it adds some extra clutter and makes the config section difficult to scan quickly.

  4. Treesitter markdown additional vim regex highlighting is recommended but it's unclear the effect it will have. We should probably add some comparison pictures to make it more clear.

@shakesbeare shakesbeare added the documentation Improvements or additions to documentation label Jul 22, 2023
@epwalsh
Copy link
Owner

epwalsh commented Jul 24, 2023

Agreed. Let's tackle this after #157.

epwalsh added a commit that referenced this issue Jul 25, 2023
@epwalsh
Copy link
Owner

epwalsh commented Jul 25, 2023

  1. Move dependency information to its own section and remove it from the Lazy.nvim setup, assuming users know how their package managers work. This will drastically cut down on the size of the Lazy.nvim setup portion and add emphasis to the configuration portion.

Addressed by 2c2a368.

@epwalsh
Copy link
Owner

epwalsh commented Jul 26, 2023

  1. Remove keybinding recommendation from Lazy.nvim setup, moving either to a system I proposed in Make gf keybinding a part of the config Make gf keybinding a part of the config #157, or to its own keybinding section as a subheader of the Configuration section. This keybind may be skipped over as its part of the installation section and it feels like it belongs in a different place anyway. This will also help to shorten the section.

Addressed by #161.

epwalsh added a commit that referenced this issue Jul 26, 2023
@epwalsh
Copy link
Owner

epwalsh commented Jul 26, 2023

  1. Configuration about templates seems to be partially duplicated. Seems intentional but it's worth taking a think about as it adds some extra clutter and makes the config section difficult to scan quickly.

Addressed by 6e2af3d.

flaviosakakibara pushed a commit to flaviosakakibara/obsidian.nvim that referenced this issue Sep 5, 2023
@epwalsh
Copy link
Owner

epwalsh commented Nov 18, 2023

Closed as completed.

@epwalsh epwalsh closed this as completed Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants