Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export of unknown monomer to HELM doesn't work #2539

Closed
AlexeyGirin opened this issue Oct 9, 2024 · 2 comments · Fixed by #2726 or #2727
Closed

Export of unknown monomer to HELM doesn't work #2539

AlexeyGirin opened this issue Oct 9, 2024 · 2 comments · Fixed by #2726 or #2727
Assignees
@AliaksandrDziarkach
Labels
HELM Bucket: Bugs related to Export to HELM format Priority: High
Milestone
Indigo-1.28.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Go to Macromolecules mode - Flex mode
  2. Load from file: Export of unknown monomer to HELM doesn't work.zip
    image
  3. Export canvas to HELM

Actual behavior
System throws exception: Convert error! array: invalid index -1 (size=4)
image

Expected behavior
System shows relevant error message: Unknown monomers are not supported

Versions

  • Ketcher Version 2.26.0-rc.1 Build at 2024-10-04; 18:45:04
  • Indigo Toolkit Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.90 (Official Build) (64-bit)
  • Win10

Issue found while testing - #1188
@AlexeyGirin AlexeyGirin added Bug Priority: Medium HELM Bucket: Bugs related to Export to HELM format labels Oct 9, 2024
AliaksandrDziarkach added a commit that referenced this issue Dec 16, 2024
@AliaksandrDziarkach
#2539 - Export of unknown monomer to HELM doesn't work
a409c11 
Fix code. Add UTs.
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Dec 16, 2024 that will close this issue
#2539 - Export of unknown monomer to HELM doesn't work #2690
Merged
7 tasks
@AliaksandrDziarkach AliaksandrDziarkach self-assigned this Dec 16, 2024
AlexanderSavelyev pushed a commit that referenced this issue Dec 17, 2024
@AliaksandrDziarkach
#2539 - Export of unknown monomer to HELM doesn't work (#2690)
cd267b4
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jan 6, 2025

Tested. Bug not fixed. Unknown monomer saves as CHEM
2025-01-06_12h40_44

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 131.0.6778.205 (Official Build) (64-bit)

Ketcher version
[Version 3.0.0-rc.1]
Indigo version
[Version 1.28.0-rc.1]

@Zhirnoff Zhirnoff reopened this Jan 6, 2025
AliaksandrDziarkach added a commit that referenced this issue Jan 15, 2025
@AliaksandrDziarkach
#2539 - Export of unknown monomer to HELM doesn't work
7ed15cd 
Fix bug. Add UTs
@AliaksandrDziarkach AliaksandrDziarkach removed a link to a pull request Jan 15, 2025
#2539 - Export of unknown monomer to HELM doesn't work #2690
Merged
7 tasks
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Jan 15, 2025 that will close this issue
#2539 - Export of unknown monomer to HELM doesn't work #2726
Merged
8 tasks
AliaksandrDziarkach added a commit that referenced this issue Jan 15, 2025
@AliaksandrDziarkach
Backmerge: #2539 - Export of unknown monomer to HELM doesn't work
6b95d54 
Backmerge to master
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Jan 15, 2025 that will close this issue
Backmerge: #2539 - Export of unknown monomer to HELM doesn't work #2727
Merged
4 tasks
AlexanderSavelyev pushed a commit that referenced this issue Jan 16, 2025
@AliaksandrDziarkach
#2539 - Export of unknown monomer to HELM doesn't work (#2726)
7e4d25c
AlexanderSavelyev pushed a commit that referenced this issue Jan 16, 2025
@AliaksandrDziarkach
Backmerge: #2539 - Export of unknown monomer to HELM doesn't work (#2727
b006f76 
)
@AlexeyGirin
Copy link
Collaborator Author

Verified.

Image

  • Ketcher Version 3.0.0-rc.2 Build at 2025-01-17; 15:37:18
  • Indigo Toolkit Version 1.28.0-rc.2.0-g1b062e641-wasm32-wasm-clang-19.0.0
  • Chrome Version 132.0.6834.84 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
HELM Bucket: Bugs related to Export to HELM format Priority: High
Projects
None yet
Milestone
Indigo-1.28.0-rc.2
3 participants
@AliaksandrDziarkach @AlexeyGirin @Zhirnoff