add support for gnome-keyring

[zabbal]

It would be great if instead of plaintext config password for mpd could be obtained from gnome keyring: https://wiki.gnome.org/GnomeKeyring

[zabbal]

https://pypi.python.org/pypi/keyring - library which could be used to implement this feature request

[grawity]

Will try, but I'm not sure if this is really useful – given that the mpd protocol is clear-text (not encrypted), and many clients even read it from an environment variable...

Do you need multiple services from that library or just GNOME Keyring? Since mpDris2 already uses GLib it could probably call gnome-keyring directly using that without a new dependency (although the library does look nice and supports the new SecretsService API).

Also, do you already have other mpd clients that use the keyring? If there are existing entries, trying to reuse them would be better than just blindly adding new ones (e.g. I have three entries for the same XMPP account, stored by different programs I once tested).

[zabbal]

As far as I know no other clients support keyring - so mpDris2 could be the first one and set an example of proper attention towards security.

Supporting SecretsService API is nice although I personally use only gnome keyring.

[doronbehar]

I wonder how this feature might work with the systemd user service.
I tried to explore this possibility with $MPD_HOST which is evaluated in my shell configurations with pass. Currently, I won't be able to make it work with the systemd user service because $MPD_HOST is empty when the systemd service starts.
Even if mpDris2.conf had an option such as passwordeval it would have worked for a shell spawn for mpDris2 but not for a systemd user service.

As for the setup with systemd user services, I ran accross a project named pam-gnupg which might help achieve this goal as well. I opened an issue on pam-gnupg with a question about such possibility.

IMHO, If we would add an option such as passwordeval and we would guide users to use pam-gnupg for systemd support of that option, we would fully reach this goal and solve this feature request.

Any opinions?

[Thaodan]

Supporting SecretsService API is nice although I personally use only gnome keyring.

Python Keyring would be a good option.