You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The code always raises Exception instead of one of its subclasses. That is not very good idea because it makes writing good unit tests hard. I fixed one more error with the unit tests on commit a163e92 that was not caught by the nosetests because the test expected any error (and got TypeError in this case). Assigning proper (or even custom) Exception subclasses would make the testing a lot more solid.
The text was updated successfully, but these errors were encountered:
Thanks. I'll look into that when I have some spare time.
Btw. I could not play videos with Kodi plugin. I think Elisa made some changes to the way videos are downloaded. But that's another issue and maybe not even on this repository.
I did the simples thing to do and created a very simple custom exception because there isn't really any Python Built-in exception that fits. I think there are still a some things that I might change like expecting Exception in elisaviihde.py code. The work I've done is in branch Tomin1:new_exceptions (especially commit ff4c636) and I'd like to hear any comments on that.
The code always raises Exception instead of one of its subclasses. That is not very good idea because it makes writing good unit tests hard. I fixed one more error with the unit tests on commit a163e92 that was not caught by the nosetests because the test expected any error (and got TypeError in this case). Assigning proper (or even custom) Exception subclasses would make the testing a lot more solid.
The text was updated successfully, but these errors were encountered: