Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dedicated listener port for envoy proxy readiness #5144

Open
arkodg opened this issue Jan 24, 2025 · 4 comments
Open

Add a dedicated listener port for envoy proxy readiness #5144

arkodg opened this issue Jan 24, 2025 · 4 comments
Labels
kind/decision A record of a decision made by the community.
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented Jan 24, 2025

Description:

Describe the issue.

Currently the envoy proxy readiness port is 19001 and is shared with prometheus. This has two issues

If this proposal is accepted, a another port 19002 would be added and dedicated for readiness

[optional Relevant Links:]

Any extra documentation required to understand the issue.

@arkodg arkodg added the kind/decision A record of a decision made by the community. label Jan 24, 2025
@arkodg arkodg added this to the Backlog milestone Jan 24, 2025
@arkodg
Copy link
Contributor Author

arkodg commented Jan 24, 2025

ptal @envoyproxy/gateway-maintainers @envoyproxy/gateway-reviewers

@shawnh2
Copy link
Contributor

shawnh2 commented Jan 28, 2025

+1, 19001 should be readiness port, 19002 can be used for prometheus

@arkodg
Copy link
Contributor Author

arkodg commented Jan 28, 2025

@shawnh2 moving prom to 19002 will be a breaking change for existing users, so prefer keeping prom on 19001, and readiness on 19002, readiness port is used internally ideally only by kubelet so it shouldnt affect users

@shawnh2
Copy link
Contributor

shawnh2 commented Jan 28, 2025

@shawnh2 moving prom to 19002 will be a breaking change for existing users, so prefer keeping prom on 19001, and readiness on 19002, readiness port is used internally ideally only by kubelet so it shouldnt affect users

SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/decision A record of a decision made by the community.
Projects
None yet
Development

No branches or pull requests

2 participants