Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Setting TCMalloc Soft Memory Limit #36680

Open
ryansmick opened this issue Oct 17, 2024 · 2 comments
Open

Enable Setting TCMalloc Soft Memory Limit #36680

ryansmick opened this issue Oct 17, 2024 · 2 comments
Labels
enhancement Feature requests. Not bugs or questions.

Comments

@ryansmick
Copy link

Title: Enable Setting TCMalloc Soft Memory Limit

Description:
Google’s TCMalloc offers the ability to set a soft memory limit in code. It works by attempting to release pages from the Page Heap if a new allocation from the OS puts tcmalloc’s total memory footprint above the soft limit. For users of Google’s TCMalloc, this seems to be an alternative to the shrink_heap action in overload manager, and we’d like to evaluate it as such.

It seems the only way to set this limit in TCMalloc is to call this function, and I don’t see any calls of this in envoy. Would it be possible to update envoy to support setting this soft limit in TCMalloc, perhaps via a bootstrap configuration or an environment variable?

@ryansmick ryansmick added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Oct 17, 2024
@tyxia tyxia removed the triage Issue requires triage label Oct 18, 2024
@tyxia
Copy link
Member

tyxia commented Oct 18, 2024

Add @nezdolik who has worked on this a lot in the past, IIRC

@nezdolik
Copy link
Member

Sounds like a reasonable feature, we could extend MemoryAllocatorManager api for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions.
Projects
None yet
Development

No branches or pull requests

3 participants