Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider where to put Program Version Number #1056

Open
JesseAbram opened this issue Sep 16, 2024 · 0 comments
Open

Reconsider where to put Program Version Number #1056

JesseAbram opened this issue Sep 16, 2024 · 0 comments
Labels
Chore changes that do not relate to a fix or feature and don't modify src or test files (eg updating deps) Discussion

Comments

@JesseAbram
Copy link
Member

In #1045 A program version is added. The PROGRAM_VERSION_NUMBER is stored in the shared crate in core In this comment https://github.com/entropyxyz/entropy-core/pull/1045/files#r1756579161 we talk about maybe moving it and why I didn't. I am happy to reconsider this at a future point
@JesseAbram JesseAbram mentioned this issue Sep 16, 2024
Merged
@JesseAbram JesseAbram added Discussion Chore changes that do not relate to a fix or feature and don't modify src or test files (eg updating deps) labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Chore changes that do not relate to a fix or feature and don't modify src or test files (eg updating deps) Discussion
Projects
Entropy Core
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JesseAbram