Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password are stored unobfuscated #45

Open
thibault opened this issue Nov 28, 2018 · 1 comment
Open

Password are stored unobfuscated #45

thibault opened this issue Nov 28, 2018 · 1 comment

Comments

@thibault
Copy link
Contributor

Unless I'm mistaken, I noticed that user passwords are stored unobfuscated in the database.

It looks like a quite annoying issue.

Passwords should be salted and hashed using a bruteforce resistant hashing function like pbkdf2.

@JulienParis
Copy link
Collaborator

This was not supposed to stay that way, but ... too many things to do for so short time ...

Still... yes it's a problem to fix quite quickly, but the thing is : we already have some users (not that much, we could re-enter the infos to recreate them), and more importantly if someone forgets its password there is currently not process in place to retrieve someone's password (for instance by sending an email with a protected route) ...

I put some ideas to fix that with the existing users here : #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants