Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] Have the Escape key clear the search #479

Open
bjherbison opened this issue Feb 29, 2024 · 11 comments
Open

[Web] Have the Escape key clear the search #479

bjherbison opened this issue Feb 29, 2024 · 11 comments
Labels
- auth Relates to Ente Auth --web Platform is web

Comments

@bjherbison
Copy link

bjherbison commented Feb 29, 2024

Is your feature request related to a problem? Please describe.
In many interfaces pressing Escape clears something recently set. In web browsers and many other applications Escape clears a search string. Since that is a common function of Escape I'm frustrated when Escape handling isn't implemented by an application or web page.

Describe the solution you'd like
When the Escape (Esc) is pressed on https://auth.ente.io/auth clear the search string and set focus to the search field.

@mnvr mnvr added --mobile Platform is mobile - auth Relates to Ente Auth triage --web Platform is web and removed --mobile Platform is mobile triage labels Mar 1, 2024
@lokicodess
Copy link

I would love to work on this issue . Can you please assign me this issue.

@lokicodess lokicodess removed their assignment Mar 5, 2024
@aakankshabhende
Copy link
Contributor

@mnvr I would like to work on this issue. Could you please assign me this?

Is this issue intended for below search bar?

image

@bjherbison
Copy link
Author

@mnvr I would like to work on this issue. Could you please assign me this?

Is this issue intended for below search bar?
image

I was intending the comment for https://auth.ente.io/auth but I didn't really specify that. It would apply for any search bar in any web application.

@mnvr
Copy link
Member

mnvr commented Mar 7, 2024

Hey @aakankshabhende, thank you for helping out! As @bjherbison mentioned, this behaviour perhaps makes sense for most (all?) search bars, so we can add it to both auth and photos search bars. But if it is simpler for you then we can start by adding it to auth first, just to reduce the scope of changes.

@klaas0
Copy link
Contributor

klaas0 commented Jun 19, 2024

It would also be cool to focus the search bar with key combination (CTRL + F)

@daeh
Copy link

daeh commented Jul 5, 2024

Adding support for escape to exit search in MacOS Desktop app (so that it's easy to see the tags). And for cmd-F to activate the search.

@SlimJim192
Copy link

It would also be cool to focus the search bar with key combination (CTRL + F)

Yep - perhaps even just default to search if window focused and you start typing.. What else could you be trying to do.

I just want to open the app, type what I want, and only use the mouse to grab the code and leave. No back and forth.

@klaas0
Copy link
Contributor

klaas0 commented Sep 24, 2024

It would also be cool to focus the search bar with key combination (CTRL + F)

Yep - perhaps even just default to search if window focused and you start typing.. What else could you be trying to do.

I just want to open the app, type what I want, and only use the mouse to grab the code and leave. No back and forth.

Well there is actually an option for that. Settings -> General -> Focus search on app start
image

@bjherbison
Copy link
Author

I don't see any Settings option on the web page.

Focus on the web page starts in the search, but once you click to get a code focus is off the text box. That's why I opened this issue and #478 .

@klaas0
Copy link
Contributor

klaas0 commented Sep 24, 2024

I don't see any Settings option on the web page.

Focus on the web page starts in the search, but once you click to get a code focus is off the text box. That's why I opened this issue and #478 .

I see, well the setting are only available in the app. You can download the app for windows with this link. Other installers are available on their website

I would highly recommend the app, it feels very snappy!

@bjherbison
Copy link
Author

I gave up Windows over a decade ago. The link for Linux download goes to a page with no download option. And once you figure out what to click after that (many links are underlined in the traditional web style, but what you need to click isn't) the installer doesn't work. Once that is fixed I might try it, but I like it in a web page.

@aakankshabhende aakankshabhende removed their assignment Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- auth Relates to Ente Auth --web Platform is web
Projects
None yet
Development

No branches or pull requests

7 participants